Ea 3925 issue item descriptions profile #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/europeana/set-api.git into EA-3925-issue-itemDescriptions-profile
gsergiu
requested changes
Sep 11, 2024
| @@ -10,7 +10,8 @@ | |||
| */ | |||
| public enum UserSetTypes implements JsonKeyword { | |||
|
|
|||
| COLLECTION("Collection"), DYNAMICCOLLECTION("DynamicCollection"), BOOKMARKSFOLDER("BookmarkFolder"), ENTITYBESTITEMSSET("EntityBestItemsSet"); | |||
| COLLECTION("Collection"), DYNAMICCOLLECTION("DynamicCollection"), BOOKMARKSFOLDER("BookmarkFolder"), ENTITYBESTITEMSSET("EntityBestItemsSet"), | |||
| GALLERY("Gallery"); | |||
There was a problem hiding this comment.
Gallery must not be included here. Only the values used in the type must be included here. For the time being we can use a constant in WebUserSetModelFields
| @@ -280,6 +292,11 @@ public boolean isCollection() { | |||
| return UserSetTypes.COLLECTION.getJsonValue().equals(getType()); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean isGallery() { | |||
| return UserSetTypes.GALLERY.getJsonValue().equals(getCollectionType()); | |||
There was a problem hiding this comment.
need to use a different constant
| @@ -594,7 +599,7 @@ public void validateWebUserSet(UserSet webUserSet, boolean isAlreadyPublished) t | |||
| @Override | |||
| public void validateCollectionSize(UserSet webUserSet, int newItems) throws ItemValidationException { | |||
There was a problem hiding this comment.
please rename to validateGallerySize
| @@ -594,7 +599,7 @@ public void validateWebUserSet(UserSet webUserSet, boolean isAlreadyPublished) t | |||
| @Override | |||
| public void validateCollectionSize(UserSet webUserSet, int newItems) throws ItemValidationException { | |||
| final int collectionMaxSize = getConfiguration().getCollectionMaxSize(); | |||
There was a problem hiding this comment.
the mthod in the configuration needs to be changed to getGalleryMaxSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.