remove duplicates from item insertion #EA-3957

europeana · Nov 28, 2024 · 0d0b3f9 · 0d0b3f9
1 parent 3663ccb
commit 0d0b3f9
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/set-web/src/main/java/eu/europeana/set/web/service/impl/BaseUserSetServiceImpl.java b/set-web/src/main/java/eu/europeana/set/web/service/impl/BaseUserSetServiceImpl.java
@@ -551,17 +551,17 @@ protected List<String> validateItemsStrings(List<String> items) throws ItemValid
     }
 
     List<String> invalidItems = new ArrayList<>();
+    String fullUrl;
     for(String item : items) {
       try {
         validateItem(item);
-        if(item.startsWith(getConfiguration().getItemDataEndpoint())) {
-          itemsWithFullUrls.add(item);
-        } else {
-          //convert to full URL
-          itemsWithFullUrls.add(
-              UserSetUtils.buildItemUrl(getConfiguration().getItemDataEndpoint(), item));
+        //convert to fullUrl if needed
+        fullUrl = (item.startsWith(getConfiguration().getItemDataEndpoint())) ? 
+            item : UserSetUtils.buildItemUrl(getConfiguration().getItemDataEndpoint(), item);
+        //do not include duplicates
+        if(!itemsWithFullUrls.contains(fullUrl)) {
+          itemsWithFullUrls.add(fullUrl);
         }
-
       } catch (ItemValidationException ex) {
         logger.trace("Invalid item: {}", item);
         invalidItems.add(item);