Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed gateway #2405

Merged
merged 21 commits into from
Jan 15, 2025
Merged

feat: embed gateway #2405

merged 21 commits into from
Jan 15, 2025

Conversation

rwd
Copy link
Contributor

@rwd rwd commented Jul 24, 2024

  • Introduces a new EmbedGateway component
    • When embed provider has user consent it renders the embed
    • when embed provider has no user consent it renders an overlay
      • overlay uses MediaCardImage to display the thumbnail or overridden default thumbnail (new multimedia icon)
      • renders text and three buttons with options to consent all, selected or only current embed provider
      • when cookieConsentRequired any button click opens the full modal with selected services per option
  • Wraps the EmbedOEmbed component on the item page with the EmbedGateway
  • Refactors PageCookiesWidget
    • to be reusable as stripped down third-party content modal
    • tracks button clicks in Matomo
  • Moves functionality from oembed package to new services utils, combining oembed providers list with cookies/services list
  • Adds the multimedia icon to the icon font

Copy link

JIRA ticket: EC-6852

@rwd rwd marked this pull request as draft July 24, 2024 10:13
Copy link

Preview deployment: https://pr-2405.portal-js.dev.eanadev.org/

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@LeoniePeters LeoniePeters marked this pull request as ready for review January 9, 2025 09:05
@rwd rwd merged commit da4ea2f into master Jan 15, 2025
17 of 18 checks passed
@rwd rwd deleted the feat/EC-6852-embed-gateway branch January 15, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants