Feat/MET-6035 Fixing depublication reason #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -328,7 +330,7 @@ private Query<DepublishRecordId> prepareQueryForDepublishRecordIds(String datase | |||
| * {@link DepublicationStatus#PENDING_DEPUBLICATION} | |||
| */ | |||
| public void markRecordIdsWithDepublicationStatus(String datasetId, Set<String> recordIds, | |||
| DepublicationStatus depublicationStatus, @Nullable Date depublicationDate) { | |||
| DepublicationStatus depublicationStatus, @Nullable Date depublicationDate, DepublicationReason depublicationReason) { | |||
|
|
|||
| // Check correctness of parameters | |||
There was a problem hiding this comment.
Perhaps add a check below? Similarly to where we check that the date must not be null when depublishing a record, we should check that the reason must not be null either?
There was a problem hiding this comment.
That is a good point, I've just added an else if condition for this scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.