GlobalExceptionHandler extends EuropeanaGlobalExceptionHandler #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsergiu
requested changes
Jul 19, 2024
annotation-web/src/main/java/eu/europeana/annotation/web/model/BatchProcessingStatus.java
Show resolved
Hide resolved
| @@ -38,18 +36,21 @@ protected I18nService getI18nService() { | |||
| // response.setError(errorMessage); | |||
| // return response; | |||
| // } | |||
|
|
|||
| @ExceptionHandler | |||
There was a problem hiding this comment.
please add the catched exception to the annotation (see also parent class)
| @@ -38,18 +36,21 @@ protected I18nService getI18nService() { | |||
| // response.setError(errorMessage); | |||
| // return response; | |||
| // } | |||
|
|
|||
| @ExceptionHandler | |||
| public ResponseEntity<EuropeanaApiErrorResponse> handleRequestBodyNotParsableError( | |||
There was a problem hiding this comment.
please renamed back method to handleBatchUploadException, so that the method name is inline with the purpose
added 2 commits
July 24, 2024 17:53
EA-3861-unify-exception-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.