Mailing list batching #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinhardt
force-pushed
the
scrum-1638-mailing-list-batching
branch
from
575316a to
08ff4bf
Compare
|
@reinhardt awesome! exactly a year after you submitted this PR I again work on this issue and can directly use this PR. |
thet
force-pushed
the
scrum-1638-mailing-list-batching
branch
2 times, most recently
from
c1af1a9 to
cda74c5
Compare
|
The test failure only seems to be caused by a differing sorting. Do you want me to look into it? |
|
@reinhardt yes please... that's funny - a different sorting in plone 5.2 and 6.0. |
|
Good point - I didn't notice the failures are for 5.2 only. Osha is on 6.0, so feel free to drop the 5.2 tests! |
Closed
|
@reinhardt done here: #300 |
thet
force-pushed
the
scrum-1638-mailing-list-batching
branch
from
cda74c5 to
bd97720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/syslabcom/scrum/issues/1638
https://github.com/syslabcom/scrum/issues/2316
Needs: