Merge pull request #18 from eonu/master

Change SecureRandom.random_bytes to Secure_random.hex to fix URLs
eucalypt-framework · Jan 1, 2019 · a382772 · a382772
2 parents 8c5a44e + b0c5107
commit a382772
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# 0.5.3
+
+#### Major changes
+
+- (**`core/helpers/maintenance.rb`**): Change dummy route to use `SecureRandom.hex` instead of `SecureRandon.random_bytes`, which used to generate invalid URLs.
+
 # 0.5.2
 
 #### Major changes

diff --git a/lib/eucalypt/core/helpers/maintenance.rb b/lib/eucalypt/core/helpers/maintenance.rb
@@ -14,9 +14,9 @@ class ApplicationController < Sinatra::Base
         unlink '*', &block
       end
     else
-      define_singleton_method(:maintenance) {|&block| get "/#{SecureRandom.random_bytes 16}", &block}
+      define_singleton_method(:maintenance) {|&block| get 3.times.map{"/#{SecureRandom.hex 8}"}.join(), &block}
     end
   else
-    define_singleton_method(:maintenance) {|&block| get "/#{SecureRandom.random_bytes 16}", &block}
+    define_singleton_method(:maintenance) {|&block| get 3.times.map{"/#{SecureRandom.hex 8}"}.join(), &block}
   end
 end
diff --git a/lib/eucalypt/version.rb b/lib/eucalypt/version.rb
@@ -1,3 +1,3 @@
 module Eucalypt
-  VERSION = '0.5.2'
+  VERSION = '0.5.3'
 end