Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector data analysis #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Detector data analysis #8

wants to merge 3 commits into from

Conversation

CFGrote
Copy link
Contributor

@CFGrote CFGrote commented Jul 26, 2016

Hi,
can someone from HZDR please review the changes and address the following:

  • possible nameclash: XRT is a well known code for X-Ray Tracing, which we are currently incorporating in
    simex_platform (branch #xrt_calculator). If I understand correctly there will be a code with the same name for x-ray scattering, soon. Can we avoid having two codes with the same acronym? Or is the hzdr xrt project a fork of the raytracer ?
  • Line 307 is still missing some information. I added this (half)sentence assuming that phasing diffraction data is part of the typical workflow for forward scattering experiments. If this is inaccurate, please remove the line, otherwise a reference to the phasing algorithm would be nice.

Thanks a lot!

@ax3l
Copy link
Member

ax3l commented Jul 26, 2016

@Flamefire naming of xrt is sub-optimal (see above; the name is not only taken by an other well established code, it's also incorporated in the same project (simex) which would cause massive confusion; links: tracer and there is even a xray telescope called xrt ^^)

@CFGrote no, it's not a fork. it's a newly written, libPMacc based, multi-GPU photon tracer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants