-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fides.js API options and improve automated tests #4314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and a few suggestions for myself!
Passing run #4739 ↗︎
Details:
Review all test suite changes for PR #4314 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for cleaning up these cypress tests! The code comments make them much easier to understand 🌟
Co-authored-by: Catherine Smith <[email protected]>
@eastandwestwind updated 👍 |
Closes PROD-1234
Description Of Changes
This is a few small changes to the FidesJS API for some different names of options/events, and some fixes and improvements to the Cypress tests.
Code Changes
FidesPreferenceToggled
->FidesUIChanged
window.config.fides
->window.config.tc_info
Deferred to follow-up issue:
window.config.tc_info
a configurable option, change default towindow.fides_config
Steps to Confirm
n/a
Pre-Merge Checklist
CHANGELOG.md