-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create LedgerAccount
type
#25
Comments
Probably not a blocker but: #24 is likely related to this in some way since both leverage HD wallets in some form. |
Some work merged in a local feature branch in #34 pending in-depth review and security audit. |
Alternate implementation from the shadowlands guy https://github.com/kayagoban/shadowlands-core/blob/master/shadowlands/credstick/ledger_ethdriver.py |
@pipermerriam has anyone attempted any progress in this direction? digging into this a bit this referenced code moved from this gist needs rebase there is a PR #34 mentions https://github.com/mikeshultz/ledger-eth-lib |
made some progress on python with ledger using #34 branch https://gist.github.com/benjyz/c4d96eb79a46c7d3d34d64f4870e2f8d managed to get the version number and address from the device. have to read up on derivation paths. for some reason ledger live uses different paths the code uses: |
should be this ETH_DERIVATION_PATH = "m/44'/60'/0'/0/0" |
maybe add a flag like this |
What is wrong
Hardware wallets are great!
How can they be implemented.
https://gist.github.com/bargst/5f896e4a5984593d43f1b4eb66f79d68
This appears to be a great starting point.
The base
Account
object should probably assume the default path. We should probably also expose an API for accessing sub-accounts at a different path assuming the ledger supports arbitrary BIP32 paths.The text was updated successfully, but these errors were encountered: