Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger support #123

Closed
benjiqq opened this issue Aug 22, 2021 · 3 comments
Closed

Ledger support #123

benjiqq opened this issue Aug 22, 2021 · 3 comments
Labels
p4 nice to have

Comments

@benjiqq
Copy link

benjiqq commented Aug 22, 2021

originally based on branch #34 I created ledgertools, a fully functional suite to interact with ledger. to merge back into eth-account some more work is needed. this library focuses on some extra security measures for signing which might be useful to add to eth-account.

https://github.com/vegaswap/ledgertools
@benjiqq benjiqq mentioned this issue Aug 22, 2021
Open
@benjiqq
Copy link
Author

benjiqq commented Sep 8, 2021

@carver made progress on this, any chance a maintainer can have a look at a PR when ready?

@carver
Copy link
Contributor

carver commented Sep 8, 2021

Sure, someone should be able to do a quick review on a PR. Any feature like this would need an "unaudited flag" like the hdwallet implementation.

No one on our team is able to work on an implementation right now.

@pacrob pacrob added the p4 nice to have label Jun 17, 2024
@pacrob
Copy link
Collaborator

pacrob commented Jun 17, 2024

Closing in favor of #25

@pacrob pacrob closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p4 nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carver @pacrob @benjiqq