-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement IERC7802 #12790
Merged
blmalone
merged 2 commits into
ethereum-optimism:develop
from
defi-wonderland:sc-feat/add-ierc7802
Nov 4, 2024
Merged
feat: implement IERC7802 #12790
blmalone
merged 2 commits into
ethereum-optimism:develop
from
defi-wonderland:sc-feat/add-ierc7802
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add IERC7802 * fix: token address fuzz error * feat: remove ERC165 contract inheritance
blmalone
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass done, I'll look more closely at this soon 👍🏻
blmalone
reviewed
Nov 1, 2024
/ci authorize 9fd55c6 |
tynes
reviewed
Nov 2, 2024
/ci authorize 9fd55c6 |
1 similar comment
/ci authorize 9fd55c6 |
* feat: add IERC20 interface support * fix: interfaces tests
/ci authorize 98f0c1e |
blmalone
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merged
via the queue into
ethereum-optimism:develop
with commit Nov 4, 2024
94ab846
49 checks passed
GrapeBaBa
pushed a commit
to optimism-java/optimism
that referenced
this pull request
Nov 13, 2024
* feat: add IERC7802 (ethereum-optimism#123) * feat: add IERC7802 * fix: token address fuzz error * feat: remove ERC165 contract inheritance * feat: add IERC20 interface support (ethereum-optimism#124) * feat: add IERC20 interface support * fix: interfaces tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ICrosschainERC20
toIERC7802
ERC165
SuperchainTokenBridge
withERC165
Tests
Adjust
SuperchainERC20
,SuperchainWETH
andSuperchainTokenBridge
testsAdditional context
This PR implements the standard proposed in ethereum/ERCs#692
Metadata
Closes #12789