Add bindings for SR2.0 #466
Conversation
mslipper
force-pushed
the
feat/sr-2.0
branch
3 times, most recently
from
e556276 to
29b1045
Compare
There was a problem hiding this comment.
I like this approach to load the chain configs from locally embedded data. Having a script to sync a new SCR revision is a nice way to decouple this repo from the SCR.
I propose that we store the chain configs in a file tree with a zip file per chain, and then lazy-load only those chains whose config is actually used. You're already lazy loading the whole config with a sync.Cond, so this pattern would just take this one step further and avoid loading 99% of data that's usually irrelevant.
| ProxyAdmin *common.Address `toml:"ProxyAdmin,omitempty" json:"ProxyAdmin,omitempty"` | ||
| SuperchainConfig *common.Address `toml:"SuperchainConfig,omitempty" json:"SuperchainConfig,omitempty"` | ||
| AnchorStateRegistryProxy *common.Address `toml:"AnchorStateRegistryProxy,omitempty" json:"AnchorStateRegistryProxy,omitempty"` | ||
| DelayedWETHProxy *common.Address `toml:"DelayedWETHProxy,omitempty" json:"DelayedWETHProxy,omitempty"` |
There was a problem hiding this comment.
maybe also already add a PermissionedDelayedWETHProxy here, I think @Inphi wanted to add this to the SR.
| Optimism *OptimismConfig `toml:"optimism,omitempty" json:"optimism,omitempty"` | ||
|
|
||
| AltDA *AltDAConfig `toml:"alt_da,omitempty" json:"alt_da,omitempty"` | ||
|
|
||
| Genesis GenesisConfig `toml:"genesis" json:"genesis"` |
There was a problem hiding this comment.
why do these 3 fields get a json spec, but not the others?
mslipper
force-pushed
the
feat/sr-2.0
branch
5 times, most recently
from
f40c47f to
e393e03
Compare
Adds bindings to the Superchain Registry 2.0 to OP Geth. The SR's data files are copied into a ZIP file via the sync-superchain.sh script. They are then mounted as an in-memory virtual file system and are read on-demand.
The structs representing each chain config are defined in this package.