Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add erc20 / erc721 transfers #1264

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add erc20 / erc721 transfers #1264

wants to merge 7 commits into from

Conversation

chuxinh
Copy link
Collaborator

@chuxinh chuxinh commented Jan 16, 2025 •
edited
Loading

#1134

Description

  • Add erc20 and erc721 transfers
  • Add unit tests

@chuxinh chuxinh requested a review from a team as a code owner January 16, 2025 17:05
@chuxinh chuxinh requested review from MSilb7 and lithium323 January 16, 2025 17:05
@chuxinh chuxinh linked an issue Jan 16, 2025 that may be closed by this pull request
ETH/ERC20 Token Transfer Intermediate Models #1134
Open
@chuxinh chuxinh mentioned this pull request Jan 16, 2025
Closed
@MSilb7
Copy link
Member

MSilb7 commented Jan 16, 2025

This isn't using the ABI right? So we still need to build that for future models.

@chuxinh
Copy link
Collaborator Author

chuxinh commented Jan 16, 2025

This isn't using the ABI right? So we still need to build that for future models.

Correct, we're not using ABI for that given it's rather standard. Discussed with @lithium323 and we don't wanna be blocked by ABI for this. He might make changes in the future :D

@chuxinh chuxinh linked an issue Jan 17, 2025 that may be closed by this pull request
ERC20 Further Enhancement Workstream #1265
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSilb7 MSilb7 Awaiting requested review from MSilb7

@lithium323 lithium323 Awaiting requested review from lithium323

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ETH/ERC20 Token Transfer Intermediate Models ERC20 Further Enhancement Workstream
2 participants
@chuxinh @MSilb7