feat: Integrate op-node with op-signer for block payload signing #59
+497
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
from
28e1d8c
to
ea91644
Compare
zhwrd
approved these changes
Oct 8, 2024
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
from
4dcaafb
to
aad65af
Compare
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
3 times, most recently
from
250005b
to
1f5c0b7
Compare
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
from
1f5c0b7
to
7f5e370
Compare
mininny
commented
Oct 29, 2024
|
|
||
| toolchain go1.22.0 | ||
|
|
||
| replace github.com/ethereum-optimism/optimism v1.4.3-0.20240125020216-6a3b1ec12399 => github.com/testinprod-io/optimism v0.0.0-20241018221952-12c4820e35fb |
There was a problem hiding this comment.
Will be reverted once the monorepo pr gets merged
zhwrd
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Design Doc: ethereum-optimism/design-docs#103
This PR adds support for op-signer to sign block payloads from op-node for p2p gossiping.
The op-signer now handles
opsigner_signBlockPayloadRPC withBlockPayloadArgsas an argument. op-signer uses the private key from the KMS to hash the arguments and the sign it this signingHash, and returns it as the RPC response.This PR is a counterpart PR of ethereum-optimism/optimism#12325
Tests