Fix decoding w/ arrays #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component can be null, resulting in an empty array being set by default,
but we are not appropriately handling it:
TypeError: Cannot read properties of undefined (reading 'name')
The newly added test captures this case.
dneilroth
approved these changes
Aug 19, 2023
|
Thanks for your contribution @MrSaints! Could you just make sure to the PR passes linter checks (https://github.com/ethereum-attestation-service/eas-sdk/actions/runs/5909071300/job/16031960766?pr=53)? |
|
Updated @lbeder :) Thanks. |
lbeder
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component can be null, resulting in an empty array being set by default, but we are not appropriately handling it:
The newly added test captures this case.