Use temporary directory for esbuild #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request :) . I improved it a bit by ditching writing to disk. Our JavaScript files are like a few kilobytes so writing to disk isn't necessary and we can easily regenerate them at startup. |
|
Thank you for the review! I noticed you reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch proposes to move
<root>/var/js/to a temporary directory.This simplifies the setup for system administrators as they no longer have to give special permissions to the user running Etherpad on
var/js/folder. It is also required for packaging Etherpad in NixPkgs: NixOS/nixpkgs#353814.