Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/restructure api #6664

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Feat/restructure api #6664

merged 4 commits into from
Sep 21, 2024

Conversation

SamTV12345
Copy link
Member

Added restful api. Can be viewed at /api-docs

@@ -141,20 +141,20 @@ version['1.3.0'] = {
setText: ['padID', 'text', 'authorId'],
};


version['2.2.2'] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why version 2.2.2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I first wanted to integrate the changes but realized that the old config is pretty much deprecated and it is better to just remove the old stuff then building on top of deprecated code.

}
}
}
}, tags: ["author"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format this file consistently please? There are a lot of keys in the same line with others and some not

@@ -369,4 +370,8 @@ exports.expressCreateServer = async (hookName: string, args: any, cb: Function)
// express-session automatically calls req.session.touch() so we don't need to do it here.
res.json({status: 'ok'});
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove those newlines

@SamTV12345 SamTV12345 merged commit 12f81cf into develop Sep 21, 2024
37 checks passed
@SamTV12345 SamTV12345 deleted the feat/restructure-api branch September 21, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants