Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat: New option to completely disable chat #5500

Draft
wants to merge 38 commits into
base: develop
Choose a base branch
from
Draft

chat: New option to completely disable chat #5500

wants to merge 38 commits into from

Commits on May 6, 2022

  1. API: Add missing await 

    This isn't strictly necessary, but it improves readability.
    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    f812e53 View commit details
    Browse the repository at this point in the history

  2. Move tar.json into JavaScript 

    This makes it possible to add comments and conditional logic.
    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    7e2472c View commit details
    Browse the repository at this point in the history

  3. lint: Fix indentation and formatting in pad.html

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    cae949a View commit details
    Browse the repository at this point in the history

  4. css: Fix class name typo

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    fec1bc0 View commit details
    Browse the repository at this point in the history

  5. PadMessageHandler: Delete unnecessary variables 

    to improve readability.
    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    9b7108d View commit details
    Browse the repository at this point in the history

  6. collab_client: Pass raw message to handleClientMessage_* hooks

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    5fe5a87 View commit details
    Browse the repository at this point in the history

  7. plugins: Don't tell clients about server-side hooks

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    595697b View commit details
    Browse the repository at this point in the history

  8. plugins: Move plugin logging to plugins.update()

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    16f84ba View commit details
    Browse the repository at this point in the history

  9. tests: chat: Consolidate all frontend chat tests

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    8d062b2 View commit details
    Browse the repository at this point in the history

  10. tests: chat: Wait for message ack

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    33c46cb View commit details
    Browse the repository at this point in the history

  11. tests: chat API: Promisify

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    5603e6b View commit details
    Browse the repository at this point in the history

  12. tests: chat API: Use assert library

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    3146d67 View commit details
    Browse the repository at this point in the history

  13. tests: chat API: Reorder assertions 

      * There's no point in asserting that the Content-Type type is JSON
    if it didn't return 200.
  * There's no point in asserting JSON body properties if the
    Content-Type isn't JSON.
  * There's no point in asserting data properties if it returned an
    error code.
    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    cb02253 View commit details
    Browse the repository at this point in the history

  14. tests: chat API: Delete unnecessary describe() calls

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    92d70e5 View commit details
    Browse the repository at this point in the history

  15. tests: chat API: Move test setup to before()

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    7b7b085 View commit details
    Browse the repository at this point in the history

  16. chat: Move click handlers to chat.js

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    f7d7d89 View commit details
    Browse the repository at this point in the history

  17. chat: Rename hide method to reduce 

    It doesn't hide: If sticky, it unsticks. Otherwise, it minimizes.
    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    b830ed9 View commit details
    Browse the repository at this point in the history

  18. chat: Make sure the icon is visible when minimizing

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    8ae5f25 View commit details
    Browse the repository at this point in the history

  19. chat: New hide method to completely hide chat

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    1cbba4e View commit details
    Browse the repository at this point in the history

  20. chat: Move chat-specific option processing to chat.js

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a1388b7 View commit details
    Browse the repository at this point in the history

  21. chat: Delete non-functional Alt-C shortcut handler

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    59848ef View commit details
    Browse the repository at this point in the history

  22. chat: Fix blur and focus in Alt-C shortcut handler

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    92cd1fe View commit details
    Browse the repository at this point in the history

  23. chat: Move Alt-C handling to chat.js

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    870191f View commit details
    Browse the repository at this point in the history

  24. chat: Move chat message handling to chat.js

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    8d3a6e5 View commit details
    Browse the repository at this point in the history

  25. chat: Move chat init to chat.js

    @rhansen
    rhansen committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a5c729a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2022

  1. chat: Move cookie pref handling to chat init in chat.js 

    It's unclear why this logic was previously triggered by connection
state changes, but it doesn't make sense for it to be there.
    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    e0f28cf View commit details
    Browse the repository at this point in the history

  2. chat: Move chat-specific pad HTML to eejsBlock_* hook functions

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    a177a62 View commit details
    Browse the repository at this point in the history

  3. chat: Move chat message handling to handleMessage hook

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    8d5fdd7 View commit details
    Browse the repository at this point in the history

  4. chat: Move chatHead client var to clientVars hook

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    2e68447 View commit details
    Browse the repository at this point in the history

  5. chat: Deprecate the chat export from the client-side chat module

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    2d3418c View commit details
    Browse the repository at this point in the history

  6. chat: Move Pad chat methods to chat.js

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    cdea600 View commit details
    Browse the repository at this point in the history

  7. chat: Move message checking to padCheck hook

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    42c22ce View commit details
    Browse the repository at this point in the history

  8. chat: Move chatHead initialization to padLoad hook

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    01f1a8b View commit details
    Browse the repository at this point in the history

  9. chat: Move message copy to padCopy hook

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    bd62104 View commit details
    Browse the repository at this point in the history

  10. chat: Move message deletion to padRemove hook

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    b6bcc09 View commit details
    Browse the repository at this point in the history

  11. chat: Move HTTP API handlers to chat.js

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    bc06ef8 View commit details
    Browse the repository at this point in the history

  12. chat: Move .etherpad import/export handling to chat.js

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    310a371 View commit details
    Browse the repository at this point in the history

  13. chat: New option to completely disable chat

    @rhansen
    rhansen committed May 7, 2022
    Configuration menu
    Copy the full SHA
    dda284c View commit details
    Browse the repository at this point in the history