Changeset: Various minor cleanups and fixes #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhansen
force-pushed
the
rhansen-changeset-cleanups
branch
from
80cb165
to
d609ea7
Compare
These functions aren't used outside of this file.
I saw this on a production system today and wanted more information.
`slicerZipperFunc()` previously assumed the provided `opOut` argument was a null Op. Enforce this by clearing it at the beginning.
Use `Object.assign()` to implement `copyOp()`, which simplifies the code and provides a return value. Also make the second op optional.
This improves readability and reduces the chances of introducing a bug.
People report that string concatenation is faster. Also, I think it's more readable.
rhansen
force-pushed
the
rhansen-changeset-cleanups
branch
from
d609ea7
to
1bbe0d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple commits; please do not squash.
This is the first batch of commits from PR #5233.
@webzwo0i This is likely to conflict with #5253.