Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Upgrade sendkeys, fix some bugs #5157

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Conversation

rhansen
Copy link
Member

@rhansen rhansen commented Aug 21, 2021

Multiple commits:

  • tests: Fix helper.linesDiv()
  • tests: Fix off-by-one bug in timeslider_follow.js
  • sendkeys: Undo formatting and unnecessary changes
  • sendkeys: Upgrade to oldest version in upstream repo
  • sendkeys: Split into separate files to match upstream
  • sendkeys: Merge in latest upstream commit that mostly works
  • sendkeys: Fix \n to {enter} conversion
  • sendkeys: Fix jQuery.fn.focus() return value
  • sendkeys: Fix Range adjustment logic
  • tests: Fix chat.js tests to accommodate new sendkeys
  • ace2_inner: Get computed style of first Element, not first Node

@rhansen rhansen marked this pull request as draft August 22, 2021 18:00
@stale
Copy link

stale bot commented Oct 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Wont Fix these things, no hate. label Oct 22, 2021
@stale stale bot closed this Oct 29, 2021
@rhansen rhansen reopened this Nov 10, 2021
@stale stale bot removed the wontfix Wont Fix these things, no hate. label Nov 10, 2021
@stale
Copy link

stale bot commented Jan 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Wont Fix these things, no hate. label Jan 12, 2022
@stale stale bot closed this Jan 19, 2022
@rhansen rhansen reopened this Jan 21, 2022
@stale stale bot removed the wontfix Wont Fix these things, no hate. label Jan 21, 2022
@stale
Copy link

stale bot commented Apr 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Wont Fix these things, no hate. label Apr 25, 2022
@stale stale bot closed this May 2, 2022
@rhansen rhansen reopened this Jul 16, 2022
@rhansen rhansen removed the wontfix Wont Fix these things, no hate. label Jul 16, 2022
@github-actions github-actions bot added the Stale No recent activity label Jun 23, 2023
@github-actions github-actions bot removed the Stale No recent activity label Jun 27, 2023
@SamTV12345 SamTV12345 marked this pull request as ready for review September 14, 2023 16:33
@SamTV12345 SamTV12345 marked this pull request as draft September 14, 2023 16:49
@github-actions github-actions bot added the Stale No recent activity label Dec 10, 2023
@github-actions github-actions bot removed the Stale No recent activity label Dec 20, 2023
@github-actions github-actions bot added the Stale No recent activity label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant