Added extra block elements to contentcollector.js

[cetra3]

Not sure whether this is the correct way to resolve this issue, but there is a bug with ep_headings which means on import, all styles are stripped out from the pad:

fourplusone/etherpad-plugins#38

I am assuming there is a more proper way to actually implement this within the actual plugin, rather than the core, but I am at a loss. If someone could point me in the right direction that would be awesome.

[JohnMcLear]

I think there is a hook in content collector no?

If not please add one :-)

----- Reply message -----
From: "cetra3" [email protected]
To: "ether/etherpad-lite" [email protected]
Subject: [etherpad-lite] Added extra block elements to contentcollector.js (#2222)
Date: Tue, Aug 12, 2014 04:13

Not sure whether this is the correct way to resolve this issue, but there is a bug with ep_headings which means on import, all styles are stripped out from the pad:

fourplusone/etherpad-plugins#38fourplusone/etherpad-plugins#38

I am assuming there is a more proper way to actually implement this within the actual plugin, rather than the core, but I am at a loss. If someone could point me in the right direction that would be awesome.

---

You can merge this Pull Request by running

git pull https://github.com/cetra3/etherpad-lite develop

Or view, comment on, or merge it at:

#2222

Commit Summary

• Added extra block elements to contentcollector to allow imports to function with ep_headings

File Changes

• M src/static/js/contentcollector.jshttps://github.com/Added extra block elements to contentcollector.js #2222/files#diff-0 (9)

Patch Links:

• https://github.com/ether/etherpad-lite/pull/2222.patch
• https://github.com/ether/etherpad-lite/pull/2222.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2222.

[JohnMcLear]

@cetra3 Did you look at the hook? I'm goign to close this pull request now because I'm 99% sure there is a hook for doing this... If not we need to add a hook.

[cetra3]

@JohnMcLear I looked within contentcollector.js for a hook but I don't think there is one specifically for the block elements, as it looks like an internal variable.

I'm not too sure about how I would add a new hook. Is there any guidance in this area? Any snippets of code to point me in the right direction?

[JohnMcLear]

See this hook: aceRegisterBlockElements

https://github.com/ether/etherpad-lite/blob/develop/src/static/js/ace2_inner.js#L2967

Is that not the one?

Or.. https://github.com/ether/etherpad-lite/blob/develop/src/static/js/contentcollector.js#L491 ?

If neither of those do it you might want to add a similar hook as https://github.com/ether/etherpad-lite/blob/develop/src/static/js/ace2_inner.js#L2967 in contentcollector.js :)

[cetra3]

Ok, yeah there should be one of those pretty much identical in contentcollector.js. I think there'll need to be a change in both the ep_headings plugin and content collector. I'll see if I have time to work on another pull request to sort this out.

Thanks for the help