Fix: Use network host parameter when launching local rpc network node #1534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I modified brownie so that the host parameter configured with the networks CLI is now used when launching a local RPC network node. This is required to enable use with dockerized RPC clients (host in this case must be set to 0.0.0.0).
Related issue: #1533
How I did it
I made some small changes to brownie/networks/rpc/*.py.
How to verify it
The modifications to the fixtures and units tests in this PR test that the network node launches and correctly configures the host parameter.
They do not test that the parameter is correctly passed from networks CLI though, this can be verified locally very easily by modifying the host parameter via the CLI and starting hardhat/ganache:
Ganache:
Hardhat:
Checklist