feat(design-system): Integrate Inkline component library as baseline #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to integrate the Inkline Vue component library as a starting point to speed component creation. We will wrap Inkline components in an Eterna components and use the Eterna components in our pages. This gives us an escape hatch should we need to replace the Inkline library in the future, and lets us define Eterna-specific details for each component.
tkaragianes
changed the title
Build:watch on the token-transformer now runs the tranform script on initial call, and then watches tokens.json and retriggers the transform script on changes.
Token transformer now splits multi-property values into separate css variables. This commit also removes the font-family hack now that Figma supports comma separated values.
Our TS rules don't allow variable shadowing. In correcting the issue, I missed one `key` that should be `property`.
luxaritas
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We plan to integrate the Inkline Vue component library as a starting point to speed component creation. We will wrap Inkline components in an Eterna components and use the Eterna components in our pages. This gives us an escape hatch should we need to replace the Inkline library in the future, and lets us define Eterna-specific details for each component.
Implementation Notes
Inkline uses CSS variables to style components. Eterna uses an override file that allows us to globally reassign Inkline's variables with our design-system standards. We can also locally override Inkline variables on a per-component basis.
Related Issues
Closes #40.