release: add prompt to draft GitHub release

[ivanvc]

This is a cherry-pick from #18886. This pull request can be merged soon without adding the automated step to undraft/release the GitHub release.

We identified the potential improvement while doing the 3.5.17 / 3.4.35 releases.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvc
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (be5982a) to head (416a9c0).

❗ Current head 416a9c0 differs from pull request most recent head 215da43

Please upload reports for the commit 215da43 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18895      +/-   ##
==========================================
- Coverage   68.78%   68.74%   -0.04%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
- Hits        24457    24446      -11     
- Misses       9671     9685      +14     
+ Partials     1430     1427       -3     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5982a...215da43. Read the comment docs.

[k8s-ci-robot]

@ivanvc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-robustness-arm64	215da43	link	true	/test pull-etcd-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ahrtr]

Should the release script continue to execute when users input 'N'? It just skips creating github draft release?

[ivanvc]

I copied the code/model from previous prompts. It's also the last step, so a failure exit here prevents nothing from later steps.

I'm okay changing it not to exit. Let me know what you think.

[ahrtr]

A user's valid input should NOT lead to release failure.

Then why add this prompt? In what cases we may select "Y" or "N"?

I think we should

• either do not add this prompt question at all; which means we always create draft github release; [this option is better?]
• or continue to execute if users input "N"; and provide a warning

[ivanvc]

That's a good point. I added this to be consistent with other steps in the release script. I'm fine dropping this pull request. Or with your latest suggested option. @jmhbnz, WDYT?