-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 15877 and bump up gRPC from v1.52.0 to v1.57.0 #16338
Conversation
One flaky robustness test execution with LazyFS link. Retry should help.
|
Signed-off-by: Chao Chen <[email protected]>
This PR seems to be almost identical to #16301 |
I have reviewed merged changes especially grpc/grpc-go#6471 and grpc/grpc-go#6481. Those should be backward compatible changes until grpc-go completely remove the deprecated API like
Thanks, I will mark the PR as ready to review with the above two arguments. |
lgtm |
Confirmed. We still need to remove the dependency on the experimental gRPC API, as tracked in #15145. Let's continue the discussion in that issue separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thx @chaochn47
The last step with gRPC update behavior changes auditing to resolve CVE etcd-io#16740 in 3.5 This PR backports etcd-io#14922, etcd-io#16338, etcd-io#16587, etcd-io#16630, etcd-io#16636 and etcd-io#16739 to release-3.5. Signed-off-by: Chao Chen <[email protected]>
The last step with gRPC update behavior changes auditing to resolve CVE etcd-io#16740 in 3.5 This PR backports etcd-io#14922, etcd-io#16338, etcd-io#16587, etcd-io#16630, etcd-io#16636 and etcd-io#16739 to release-3.5. Signed-off-by: Chao Chen <[email protected]>
The last step with gRPC update behavior changes auditing to resolve CVE etcd-io#16740 in 3.5 This PR backports etcd-io#14922, etcd-io#16338, etcd-io#16587, etcd-io#16630, etcd-io#16636 and etcd-io#16739 to release-3.5. Signed-off-by: Chao Chen <[email protected]>
Fix #16290
Pending to evaluate potential breaking changes mentioned in #15145 (comment).
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.