Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Draft 6 #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for Draft 6 #59

wants to merge 1 commit into from

Conversation

J-T-McC
Copy link
Contributor

@J-T-McC J-T-McC commented Aug 14, 2024

Add support for Draft 6

  • updates json library dependency version for draft 6 support
  • adds assertions for some draft 6 scenarios
  • upgrades phpunit to version 10
  • fixes github build pipeline

- updates json library dependency version for draft 6 support
- adds assertions for some draft 6 scenarios
- upgrades phpunit to version 10
- fixes github build pipeline
Copy link

codeclimate bot commented Aug 14, 2024

Code Climate has analyzed commit 032bdb6 and detected 0 issues on this pull request.

View more on Code Climate.

@J-T-McC
Copy link
Contributor Author

J-T-McC commented Aug 15, 2024

@estahn (Pinging for visibility, no rush). Hey there, me again. This MR is to support 6.0 of justinrainbow/json-schema which has fairly good support for the Draft-6 spec.

I ran it against a fairly big project that uses draft 4 schemas with no issues but might be worth a major bump just incase there's a hidden breaking change in the json-schema library for draft 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant