-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eim 46 styling gui #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes but otherwise LGTM
src/components/LoadConfig.vue
Outdated
</svg> | ||
</div> | ||
<h2 class="option-title">Load Configuration</h2> | ||
<p class="option-description">Load an existing configuration file to start the installation process</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to implement some drag and drop functionality ? It would be cool to drag and drop the config here to load config files for users. If possible we can add it for future feature request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe unrelated to this PR but worth looking into it. I've received this error while cmake extraction. About this error, when the error happens the UI is frozen and can't go back to the start. I suggest to add a way to obtain the setup log at any given point of the setup and a way to cancel the setup. |
For any OS, if users need to install any prerequisites themselves, please provide a link within the wizard. This will help avoid users having to go through the documentation to figure out what needs to be installed. |
Good to have: |
Hi @Hahihula Thanks for PR. Good progress. See if we can implement the following type of UI: The header, footer, and wizard size should remain fixed across platforms, while the middle section will be used for the installation content.Changing the content area size for every screen disrupts a professional appearance. See if we can consider this approach. @pedrominatel @igrr Please share your thoughts with us before Petr considers the revamp. |
Yes, we detect the prerequisites from homebrew. Which version did you used? Isn't this the old issue with the version from dmg package? Only working is probably the binary one. The version with dmg or msi will be used After we start with version management and as they are no use as of today, I did not spend time resolving these permissions issues. |
<n-card class="prerequisites-list"> | ||
<template #header> | ||
<div class="card-header"> | ||
<span class="header-title">Required Prerequisites</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant. Change just to Prerequisites
.
</tbody> | ||
</table> | ||
<div class="installation-progress"> | ||
<h1 class="title">ESP-IDF Installation Progress</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can avoid using ESP-IDF everywhere. The installation manager title in red makes this clear, and we could remove it where it is not needed.
} | ||
|
||
.header { | ||
background-color: #dc2626; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If red is the color, change to the Espressif logo red (#e7352c). I know it's nitpicking but it's part of the branding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was meant to be Espressif red, replacing all around the app!
85dd73d
to
bec61a1
Compare
@kolipakakondal, IMHO we need to keep the UI as simple as possible, with the possibility of installing with some of the configurations settled as default. In this proposal, we can simplify the interface by adding the links for each step in a way that the user can return to that specific part or go directly to the installation without setting anything (if possible). Do we need to show the dependency check results every time? Does this information matter if all dependencies match? The download server settings can be included in the general setting and should be used only if necessary. |
Hi @Hahihula , I guess there are several suggestions to change the main template, just take window height in consideration, and attempt to keep it under 900pixels Also there is some redundancy on the installing screen, maybe we can remove one of these 2 sections: |
@kolipakakondal @pedrominatel Ok, so what about letting the user on the starting page to a)load config b) select "expert mode" instalation (which will lead to current wizard) c) select "default/simplified installation" which will not ask him any question unless hitting a wall ? As we support complete headless and non-interactive installation, this should actually be achievable without any more effort (just with the small UI redo) |
Sounds good to me! |
023fed4
to
040e5ac
Compare
Hi @pedrominatel Thanks for the proposal. This looks good to me as well. On the left-hand side, we can show all the steps involved in the installation process and highlight the current one. We will continue to drive the major actions through the bottom button. I don’t think we need to support back-and-forth navigation to avoid potential issues with the installation process. In the case of Simplified Installation, we can run all the steps in automatic mode and show only the progress. For Expert Installation, we can allow the user to configure each step and proceed to the next step only by clicking the 'Next' button. @Hahihula Please see if we can implement this for the initial version. |
8856fcf
to
b8f0580
Compare
Changed the visual appearance of the installer.