Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eim 46 styling gui #16

Merged
merged 14 commits into from
Dec 3, 2024
Merged

Eim 46 styling gui #16

merged 14 commits into from
Dec 3, 2024

Conversation

Hahihula
Copy link
Collaborator

Changed the visual appearance of the installer.
image
image
image
image
image
image
image
image
image
image
image
image

Copy link

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes but otherwise LGTM

</svg>
</div>
<h2 class="option-title">Load Configuration</h2>
<p class="option-description">Load an existing configuration file to start the installation process</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to implement some drag and drop functionality ? It would be cool to drag and drop the config here to load config files for users. If possible we can add it for future feature request.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added drag&drop ( you can drop the file anywhere on the window in this step ) even with animated highlight .
image
image

src/components/wizard_steps/InstallationPathSelect.vue Outdated Show resolved Hide resolved
src/components/wizard_steps/MirrorSelect.vue Show resolved Hide resolved
src/components/wizard_steps/MirrorSelect.vue Outdated Show resolved Hide resolved
src/components/wizard_steps/VersionSelect.vue Outdated Show resolved Hide resolved
@brianignacio5
Copy link

brianignacio5 commented Nov 21, 2024

Maybe unrelated to this PR but worth looking into it. I've received this error while cmake extraction.

image

About this error, when the error happens the UI is frozen and can't go back to the start. I suggest to add a way to obtain the setup log at any given point of the setup and a way to cancel the setup.

@kolipakakondal
Copy link
Collaborator

Hi @HahihulaDo we detect prerequisites from Homebrew as well? I see CMake is not being detected through its installation.

Screenshot 2024-11-21 at 11 19 21 AM

@kolipakakondal
Copy link
Collaborator

Can we simplify the layout to accommodate more information in less space? Instead of showing the missing prerequisites below, we could list all prerequisites in the top section itself. After the check, it can display what’s missing and what will be installed using status icons. With that approach, the user can avoid scrolling down to see the Missing Prerequisites section.

Screenshot 2024-11-21 at 11 21 52 AM

@kolipakakondal
Copy link
Collaborator

For any OS, if users need to install any prerequisites themselves, please provide a link within the wizard. This will help avoid users having to go through the documentation to figure out what needs to be installed.
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/get-started/linux-macos-setup.html?highlight=dfu%20util#step-1-install-prerequisites

Screenshot 2024-11-21 at 11 29 10 AM

@kolipakakondal
Copy link
Collaborator

Good to have:
If there is a persistent issue with installing tools or prerequisites and the user would like to check the logs, it would be great if we could provide a link that directly opens the log file.

@kolipakakondal
Copy link
Collaborator

Hi @Hahihula Thanks for PR. Good progress. See if we can implement the following type of UI: The header, footer, and wizard size should remain fixed across platforms, while the middle section will be used for the installation content.Changing the content area size for every screen disrupts a professional appearance. See if we can consider this approach.

@pedrominatel @igrr Please share your thoughts with us before Petr considers the revamp.

e4f9f72086bf4de4a4b333e3a0033931

@Hahihula
Copy link
Collaborator Author

Hi @HahihulaDo we detect prerequisites from Homebrew as well? I see CMake is not being detected through its installation.

Yes, we detect the prerequisites from homebrew. Which version did you used? Isn't this the old issue with the version from dmg package? Only working is probably the binary one. The version with dmg or msi will be used After we start with version management and as they are no use as of today, I did not spend time resolving these permissions issues.

<n-card class="prerequisites-list">
<template #header>
<div class="card-header">
<span class="header-title">Required Prerequisites</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant. Change just to Prerequisites.

</tbody>
</table>
<div class="installation-progress">
<h1 class="title">ESP-IDF Installation Progress</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can avoid using ESP-IDF everywhere. The installation manager title in red makes this clear, and we could remove it where it is not needed.

}

.header {
background-color: #dc2626;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If red is the color, change to the Espressif logo red (#e7352c). I know it's nitpicking but it's part of the branding.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was meant to be Espressif red, replacing all around the app!

@pedrominatel
Copy link
Member

pedrominatel commented Nov 21, 2024

@kolipakakondal, IMHO we need to keep the UI as simple as possible, with the possibility of installing with some of the configurations settled as default.
I'm attaching this UI for you to take a look at (be kind, I'm not a designer ).

Screenshot 2024-11-21 at 20 33 39

In this proposal, we can simplify the interface by adding the links for each step in a way that the user can return to that specific part or go directly to the installation without setting anything (if possible).
The part with the ESP-IDF version selection and the SoCs can be done in just one step and the version should reflect on the supported target list.

Do we need to show the dependency check results every time? Does this information matter if all dependencies match?

The download server settings can be included in the general setting and should be used only if necessary.

@Fabricio-ESP
Copy link
Collaborator

Fabricio-ESP commented Nov 21, 2024

Hi @Hahihula ,
I noticed the height of the template window is too high from start, most people still use fullhd screens and the application is occupying all vertical height and still the footer is not visible on startup, forcing users to maximize the window to see it. Even with that the "Select your starting point!" para shows a scroll bar, it is better to make it wider and reduce height.

I guess there are several suggestions to change the main template, just take window height in consideration, and attempt to keep it under 900pixels

Also there is some redundancy on the installing screen, maybe we can remove one of these 2 sections:
image

@Hahihula
Copy link
Collaborator Author

Hahihula commented Nov 21, 2024

@kolipakakondal @pedrominatel Ok, so what about letting the user on the starting page to a)load config b) select "expert mode" instalation (which will lead to current wizard) c) select "default/simplified installation" which will not ask him any question unless hitting a wall ? As we support complete headless and non-interactive installation, this should actually be achievable without any more effort (just with the small UI redo)

@pedrominatel
Copy link
Member

@kolipakakondal @pedrominatel Ok, so what about letting the user on the starting page to a)load config b) select "expert mode" instalation (which will lead to current wizard) c) select "default/simplified installation" which will not ask him any question unless hitting a wall ? As we support complete headless and non-interactive installation, this should actually be achievable without any more effort (just with the small UI redo)

Sounds good to me!

@Hahihula
Copy link
Collaborator Author

Hahihula commented Nov 23, 2024

hope this will be ok:
image

@kolipakakondal
Copy link
Collaborator

kolipakakondal commented Nov 29, 2024

@kolipakakondal, IMHO we need to keep the UI as simple as possible, with the possibility of installing with some of the configurations settled as default. I'm attaching this UI for you to take a look at (be kind, I'm not a designer ).

Screenshot 2024-11-21 at 20 33 39 In this proposal, we can simplify the interface by adding the links for each step in a way that the user can return to that specific part or go directly to the installation without setting anything (if possible). The part with the ESP-IDF version selection and the SoCs can be done in just one step and the version should reflect on the supported target list.

Do we need to show the dependency check results every time? Does this information matter if all dependencies match?

The download server settings can be included in the general setting and should be used only if necessary.

Hi @pedrominatel Thanks for the proposal. This looks good to me as well. On the left-hand side, we can show all the steps involved in the installation process and highlight the current one. We will continue to drive the major actions through the bottom button.

I don’t think we need to support back-and-forth navigation to avoid potential issues with the installation process.

In the case of Simplified Installation, we can run all the steps in automatic mode and show only the progress. For Expert Installation, we can allow the user to configure each step and proceed to the next step only by clicking the 'Next' button.

@Hahihula Please see if we can implement this for the initial version.

@Hahihula
Copy link
Collaborator Author

Hahihula commented Nov 29, 2024

Ok, I've added the sidebar to the expert installation:
image
And also made previous steps clickable so user can actually go back, but only before the installation starts...

@Hahihula Hahihula merged commit fe7b2f2 into master Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants