Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #173

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Update CONTRIBUTING.md #173

merged 1 commit into from
Jan 2, 2025

Conversation

horw
Copy link
Member

@horw horw commented Jan 2, 2025

Description

The Makefile is actually in the docs/en directory.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@horw horw requested a review from hfudev January 2, 2025 08:57
@horw horw force-pushed the contributing-patch branch from 3f869cb to 7a9e80b Compare January 2, 2025 09:08
@@ -54,7 +54,7 @@ doc = [
homepage = "https://github.com/espressif/idf-build-apps"
repository = "https://github.com/espressif/idf-build-apps"
documentation = "https://docs.espressif.com/projects/idf-build-apps"
changelog = "https://github.com/espressif/idf-build-apps/blob/master/CHANGELOG.md"
changelog = "https://github.com/espressif/idf-build-apps/blob/main/CHANGELOG.md"
Copy link
Member Author

@horw horw Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The master branch does not exist.

@hfudev hfudev merged commit 26fe64d into main Jan 2, 2025
4 checks passed
@hfudev
Copy link
Member

hfudev commented Jan 2, 2025

Thank you for the fix! @horw

@hfudev hfudev deleted the contributing-patch branch January 2, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants