Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip etherent patch if already applied #143

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

Jason2866
Copy link
Contributor

No description provided.

@brentru
Copy link

brentru commented Oct 26, 2023

@Jason2866 Seems to be a failure here (I am running into the same thing on my fork :) ) :

Compilation failed because esp32-hal-sr.c (in "arduino" component) includes esp_mn_speech_commands.h, provided by esp-sr component(s).
However, esp-sr component(s) is not in the requirements list of "arduino".
To fix this, add esp-sr to PRIV_REQUIRES list of idf_component_register call in /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/components/arduino/CMakeLists.txt.

However, the file /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/components/arduino/CMakeLists.txt is not present in master...

@Jason2866
Copy link
Contributor Author

@brentru I removed SR (and other stuff) we don't need / use. So no issue for me.

@me-no-dev
Copy link
Member

Though unrelated, please add esp-sr to PRIV_REQUIRES or REQUIRES in CMakeLists.txt.

@brentru
Copy link

brentru commented Oct 27, 2023

@me-no-dev This (https://github.com/espressif/esp32-arduino-lib-builder/blob/master/CMakeLists.txt) CMakeLists.txt, or another one? The one in root doesn't contain PRIV_REQUIRES or REQUIRES.

@Jason2866
Copy link
Contributor Author

Jason2866 commented Oct 27, 2023

@me-no-dev This (https://github.com/espressif/esp32-arduino-lib-builder/blob/master/CMakeLists.txt) CMakeLists.txt, or another one? The one in root doesn't contain PRIV_REQUIRES or REQUIRES.

@brentru This one https://github.com/espressif/arduino-esp32/blob/master/CMakeLists.txt

@me-no-dev me-no-dev merged commit 8129486 into espressif:master Nov 9, 2023
7 checks passed
@Jason2866 Jason2866 deleted the patch-1 branch November 10, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants