Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package kaomoji 0.2.0 #137

Merged
merged 2 commits into from
Nov 9, 2024
Merged

add package kaomoji 0.2.0 #137

merged 2 commits into from
Nov 9, 2024

Conversation

citrusmunch
Copy link
Contributor

hello, i made a kaomoji package! („• ᴗ •„)

@smeech
Copy link
Collaborator

smeech commented Nov 3, 2024

A straightforward package of trigger/replace pairs. No shell, script, cmd, or malicious code.

Would you kindly rename the package simply to "kaomoji" as in your heading, please? The "espanso-" prefix is self-evident. It'll mean renaming your path to packages/kaomoji/0.2.0/ and changing the name in your _manifest.yml I'm afraid ☹️.

Thank you for your submission!

@citrusmunch
Copy link
Contributor Author

renamed! thanks for the swift reply :)

@smeech
Copy link
Collaborator

smeech commented Nov 4, 2024

Thank you.

I'm intrigued by your liberal use of double quote marks ". Many people use them for values (and you'd need them for the values that begin with [ or { etc.) but I haven't seen them around keys before, and didn't realise that would even work. I would have written your first trigger simply as:

  - replace: (* ^ ω ^)
    search_terms: ["'w", "'*"]
    trigger: ;kao joy 00

for example. Was there a reason for this?

I suspect the reason why some kao don't render in the search bar may be related to espanso/espanso#974 and espanso/espanso#2103

@smeech smeech merged commit d82095c into espanso:main Nov 9, 2024
1 check passed
@citrusmunch
Copy link
Contributor Author

hi @smeech, sorry to necro, but i wanted to thank you for the feedback!

for the double quotes i absolutely went overboard and didn't realize haha. initially i was using a 'kao for the trigger (single quote) and i guess never undid that. also some of the replacements use quotes and i wanted to uniformly double quote all of them. hoping to clean all that up in the future.

and thanks for the hint on the rendering-- will take a look!! (⁀ᗢ⁀)

@citrusmunch citrusmunch deleted the add-kaomoji branch December 8, 2024 15:17
@smeech
Copy link
Collaborator

smeech commented Dec 8, 2024

You're welcome. Many people are wedded to double-quotes around replacement texts, even when they're not necessary, which is fine, but was the reason for my article in the docs. I was just suprised to see them around "trigger:", and "replace:" etc!

Best wishes, and thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants