-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add curl config #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A straightforward text replacement package.
Well documented, and tags:
in _manifest.yml
.
Looks safe to merge, but does present various curl
commands, so needs double-checking/approval by someone more experienced with these than me.
I've done some reading around It might be interesting to add a global variable, along the lines of: global_vars:
- name: curlform
type: form
params:
layout: Target https://[[URL]] and replace all instances of matches:
- trigger: ":curl:"
replace: "curl --request GET https://{{curlform.URL}}" The other optional variables: |
packages/curl/0.1.0/package.yml
Outdated
replace: "curl --request PATCH https://example.com" | ||
|
||
- trigger: ":curldata:" | ||
replace: "curl --request POST --header 'Content-Type: multipart/form-data' --form 'key=value' http://example.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for the mix of https:
and http:
? The former throughout might be safer? I'd be happy to merge if this is addressed (unless there are good reasons not to).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I added the relevant global variables as per your prompt
just a suggestion
Just a suggestion
@smeech Thank you very much for your guidance. I have learned a better way of configuration from this pr |
No description provided.