Skip to content

Commit

Permalink
module callback_server no longer needed either
Browse files Browse the repository at this point in the history
  • Loading branch information
ivmarkov committed Jan 23, 2024
1 parent 1ab2d03 commit 4ef9581
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 19 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [0.??.?] - ????-??-??
* Breaking change in module `utils::asyncify` - the whole module is now removed as all the functionality is folded directly into `esp-idf-svc`. The one trait in there - `Unblocker` now lives in a new module - `unblock`
* Breaking change in module `ws::callback_server`: the whole module is removed because it was only a used by module `utils::asyncify` which is also removed
* Breaking change in module `utils::mutex` - the whole module is now removed as all the functionality is folded directly into `esp-idf-svc`
* Breaking change in modules `mqtt::client` and `utils::mqtt::client`: The `Event` structure, and its associated `Message` and `MessageImpl` traits simplified significantly, allowing for much more ergonomic event processing, thanks to GATs and async-fn-in-trait which are now stable:
* Introduced a new single-method trait: `Event` with method `payload` returning `EventPayload`
Expand All @@ -17,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Additionally, the blocking and async versions of `Middleware` are now generified by the `Handler` type, so that they have access
to the Handler's error type and are therefore free to implement their error type in terms of a composition between the handler error type and the error types of other functions they are calling
* Breaking change in traits `event_bus::asynch::Receiver` and `event_bus::asynch::Sender` - rolled back the change where the `send`/`recv` methods took `&self` and restored `&mut self` as the `&self` requirement was too constraining
* Breaking change in module `ws::callback_server`: the whole module is removed because it was only supported module `utils::asyncify` which is also removed
* Bumped the MSRV version to 1.75 and removed the `nightly` feature requirement from all async traits
* Updated the `embedded-hal-async` dependency to 1.0
* Added the opt-out `asyncify` feature. Disabling this feature removes the `atomic-waker` dependencies and removes the `utils::asyncify` module
Expand Down
19 changes: 0 additions & 19 deletions src/ws.rs
Original file line number Diff line number Diff line change
Expand Up @@ -111,25 +111,6 @@ pub mod server {
}
}

pub mod callback_server {
pub use super::*;

pub trait SessionProvider {
type Session: Clone + Send + PartialEq + Debug;

fn session(&self) -> Self::Session;

fn is_new(&self) -> bool;
fn is_closed(&self) -> bool;
}

pub trait SenderFactory: ErrorType {
type Sender: Sender<Error = Self::Error>;

fn create(&self) -> Result<Self::Sender, Self::Error>;
}
}

pub mod asynch {
pub use super::{ErrorType, Fragmented, FrameType};

Expand Down

0 comments on commit 4ef9581

Please sign in to comment.