-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace box-emu-hal (non-component) with actual box-emu component and use esp-box component from espp #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅Static analysis result - no issues found! ✅ |
finger563
added
enhancement
New feature or request
esp32-s3-box
esp32-s3-box-3
hal
hardware abstraction layer
labels
Jul 3, 2024
…omponent instead of box-emu-hal component
…se new box-emu component
finger563
changed the title
Feature/espp update and esp box component
Replace box-emu-hal (non-component) with actual box-emu component and use esp-box component from espp
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
box-emu-hal
component which was just a collection of static functions in a namespace (and not very well designed)espp
submodule to have newestEspBox
component which automatically detects and configures touch, display, and audio for both ESP32-S3-BOX and ESP32-S3-BOX-3 - no longer requiring a recompile / menuconfig to select box version! 🎉box-emu
component which leveragesEspBox
component and provides a nicer interfaceMotivation and Context
Related espp PR: esp-cpp/espp#264
This PR enables the box-emu code to run on all versions of the box-emu as well as all versions of the esp-box, without needing to recompile. Previously, you would have to recompile if you wanted to target different versions of the esp-box (but not if you wanted to target different versions of the box-emu).
Finally, this helps clean up the code and remove code that's a little more esp-box related, now that it has an actual component class for the
BoxEmu
and it uses theespp::EspBox
component as well.Additionally, this code also speeds up file access by increasing the allocation unit size configured for the sd card.
How has this been tested?
box-emu/example
on Box-3 (V1)box-emu/example
on Box (V1)box-emu/example
on Box (V0)Building and running
main
on Box-3 (V1) and testing all the emulators :)Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Box-3 V1:
Box V1:
Box V0:
Types of changes
Checklist:
Software
.github/workflows/build.yml
file to add my new test to the automated cloud build github action.