Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Python 3 for pre-commit #70

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Jul 10, 2024

Switch to Python 3 for pre-commit to make it work with Ubuntu. Otherwise:

user@Matter:~/Documents/ESP32_Display_Panel$ pre-commit run --all-files
astyle formatter.........................................................Passed
Check copyright notices..................................................Passed
flake8...................................................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
mixed line ending........................................................Passed
Update when configuration files change...................................Failed
- hook id: sync-conf-files
- exit code: 1

Executable `python` not found

Update when versions change..............................................Failed
- hook id: check-file-versions
- exit code: 1

Executable `python` not found

@Lzw655 Lzw655 self-requested a review July 10, 2024 08:15
Copy link
Collaborator

@Lzw655 Lzw655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lboue, thank you for the contribution. Let's merge it!

@Lzw655 Lzw655 merged commit f6200e2 into esp-arduino-libs:master Jul 10, 2024
3 checks passed
@lboue lboue deleted the patch-4 branch July 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants