-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mim 2314 reject verify peer without cacertfile #4391
base: master
Are you sure you want to change the base?
Conversation
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 764f432 small_tests_27 / small_tests / 764f432 small_tests_26 / small_tests / 764f432 small_tests_27_arm64 / small_tests / 764f432 ldap_mnesia_27 / ldap_mnesia / 764f432 s2s_SUITE:both_tls_required:simple_message{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alice_simple_message_1894@localhost/res1">>,
escalus_tcp,<0.53796.0>,
[{event_manager,<0.53791.0>},
{server,<<"localhost">>},
{username,<<"alicE_simple_message_1894">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.53791.0>},
{server,<<"localhost">>},
{username,<<"alicE_simple_message_1894">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_simple_message_1894">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_simple_message_1894">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"05915414ac6e5538">>}]},
10000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{s2s_SUITE,'-simple_message/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/s2s_SUITE.erl"},
{line,178}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,179... s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} ldap_mnesia_26 / ldap_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} dynamic_domains_mysql_redis_27 / mysql_redis / 764f432 internal_mnesia_27 / internal_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 764f432 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 764f432 graphql_server_SUITE:admin_cli:clustering_tests:remove_alive_from_cluster{failed,
{graphql_server_SUITE,end_per_testcase,
{'EXIT',
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mnesia,system_info,
[is_running]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,has_mnesia,1,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,31}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,53}]},
{graphql_server_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,121}]},
{test_server,do_end_per_testcase,4,
[{file,"test_server.erl"},{line,1638}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1346}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}}} graphql_server_SUITE:admin_cli:clustering_tests:remove_node_test{error,{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,3}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,258}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,241}]},
{graphql_server_SUITE,remove_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,225}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:stop_node_test{error,{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,3}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,258}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,241}]},
{graphql_server_SUITE,stop_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,230}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} metrics_api_SUITE:all_metrics_are_global:end_per_group{error,
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,699}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{timeout => 30000,node => mongooseim2@localhost},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{metrics_helper,finalize_by_all_metrics_are_global,2,
[{file,"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,30}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1391}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} metrics_api_SUITE:global:cluster_size{skip,
{failed,
{metrics_api_SUITE,init_per_testcase,
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,699}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{timeout => 30000,node => mongooseim2@localhost},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{metrics_api_SUITE,'-ensure_nodes_not_clustered/1-lc$^1/1-1-',
2,
[{file,
"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
{line,475}]},
{metrics_api_SUITE,ensure_nodes_not_clustered,1,
... persistent_cluster_id_SUITE:rdbms:all_nodes_in_the_cluster_have_the_same_cluster_id{failed,
{persistent_cluster_id_SUITE,end_per_testcase,
{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,699}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{timeout => 30000,node => mongooseim2@localhost},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{persistent_cluster_id_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/persistent_cluster_id_SUITE.erl"},
{line,108}]},
{test_server,do_end_per_testcase,4,
[{file,"test_serv... persistent_cluster_id_SUITE:rdbms:cluster_id_is_restored_to_mnesia_from_rdbms_if_mnesia_lost{error,
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,699}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{timeout => 30000,node => mongooseim@localhost},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{persistent_cluster_id_SUITE,
cluster_id_is_restored_to_mnesia_from_rdbms_if_mnesia_lost,1,
[{file,
"/home/circleci/project/big_tests/tests/persistent_cluster_id_SUITE.erl"},
{line,174}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} service_domain_db_SUITE:init_per_suite{'EXIT',
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_service,loaded_services_with_opts,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{dynamic_services,save_services,2,
[{file,
"/home/circleci/project/big_tests/tests/dynamic_services.erl"},
{line,15}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,2151}]},
{service_domain_db_SUITE,init_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,198}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1391}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} service_mongoose_system_metrics_SUITE:all_clustered_mongooses_report_the_same_client_id{failed,
{service_mongoose_system_metrics_SUITE,end_per_testcase,
{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,699}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{timeout => 30000,node => mongooseim2@localhost},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{service_mongoose_system_metrics_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,160}]},
{test_server,do_end_per_testcase,... service_mongoose_system_metrics_SUITE:log_transparency:just_removed_from_config_logs_question{error,
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_service,ensure_stopped,
[service_mongoose_system_metrics]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{service_mongoose_system_metrics_SUITE,disable_system_metrics,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,437}]},
{service_mongoose_system_metrics_SUITE,
just_removed_from_config_logs_question,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,283}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} system_probes_SUITE:mnesia:mnesia_info{error,{test_case_failed,"Incorrect number of instrumentation events - matched: 0, expected: positive"}} system_probes_SUITE:end_per_suite{error,{test_case_failed,"Instrumentation events that were logged, but not tested:\n[{mnesia_info,#{}}]\nYou need to test them with instrument_helper:assert/3"}} pgsql_cets_27 / pgsql_cets / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} mysql_redis_27 / mysql_redis / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_mnesia_26 / pgsql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_mnesia_27 / pgsql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} mssql_mnesia_27 / odbc_mssql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} cockroachdb_cets_27 / cockroachdb_cets / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 764f432 mam_SUITE:cassandra_muc_all:muc06:muc_message_with_stanzaid{failed,
{mam_SUITE,end_per_testcase,
{'EXIT',
{{room_archive_size,0,[{times,200,1}],ok},
[{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/../test/common/mongoose_helper.erl"},
{line,359}]},
{mam_helper,wait_for_room_archive_size,3,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,800}]},
{mam_helper,clean_room_archive,1,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,744}]},
{mam_helper,destroy_room,1,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,737}]},
{mam_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
{line,967}]},
{test_server,do_end_per_testcase,4,
[{file,"test_server.erl"},{line,1638}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1346}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}}} small_tests_27 / small_tests / 764f432 small_tests_27_arm64 / small_tests / 764f432 small_tests_26 / small_tests / 764f432 ldap_mnesia_27 / ldap_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} dynamic_domains_mysql_redis_27 / mysql_redis / 764f432 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 764f432 internal_mnesia_27 / internal_mnesia / 764f432 pubsub_SUITE:dag+basic:publish_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-publish_test/1-fun-0-',1,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,453}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} pubsub_SUITE:dag+basic:publish_only_retract_items_scope_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-publish_only_retract_items_scope_test/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,658}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 764f432 mysql_redis_27 / mysql_redis / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 764f432 pgsql_cets_27 / pgsql_cets / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_mnesia_27 / pgsql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} cockroachdb_cets_27 / cockroachdb_cets / 764f432 pubsub_SUITE:dag+basic:publish_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alice_publish_test_2851@localhost/res1">>,
escalus_tcp,<0.74275.0>,
[{event_manager,<0.74207.0>},
{server,<<"localhost">>},
{username,<<"alicE_publish_test_2851">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.74207.0>},
{server,<<"localhost">>},
{username,<<"alicE_publish_test_2851">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_publish_test_2851">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_publish_test_2851">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"6b81a29fe02ab07e">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,433}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-publish_test/1-fun-0-',1,
[{file,"/home/circleci/project/big_tes... s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_mnesia_26 / pgsql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} mssql_mnesia_27 / odbc_mssql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 764f432 ldap_mnesia_26 / ldap_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} ldap_mnesia_27 / ldap_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} internal_mnesia_27 / internal_mnesia / 764f432 pubsub_SUITE:dag+basic:request_all_items_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-request_all_items_test/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,543}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} pubsub_SUITE:tree+basic:retract_when_user_goes_offline_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-retract_when_user_goes_offline_test/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,611}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} pubsub_SUITE:tree+node_config:set_configuration_errors_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_cets_27 / pgsql_cets / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} cockroachdb_cets_27 / cockroachdb_cets / 764f432 pubsub_SUITE:dag+collection_config:disable_persist_items_leaf_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_disable_persist_items_leaf_test_2883@localhost/res1">>,
escalus_tcp,<0.74902.0>,
[{event_manager,<0.74891.0>},
{server,<<"localhost">>},
{username,<<"alicE_disable_persist_items_leaf_test_2883">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.74891.0>},
{server,<<"localhost">>},
{username,
<<"alicE_disable_persist_items_leaf_test_2883">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_disable_persist_items_leaf_test_2883">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_disable_persist_items_leaf_test_2883">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"407db4911a287888">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,433}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.... s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} mysql_redis_27 / mysql_redis / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_mnesia_26 / pgsql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} mssql_mnesia_27 / odbc_mssql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_mnesia_27 / pgsql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 764f432 ldap_mnesia_26 / ldap_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} ldap_mnesia_27 / ldap_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} internal_mnesia_27 / internal_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_cets_27 / pgsql_cets / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} cockroachdb_cets_27 / cockroachdb_cets / 764f432 rdbms_SUITE:tagged_rdbms_queries:test_incremental_upsert{error,{{assertEqual,[{module,rdbms_SUITE},
{line,629},
{expression,"selected_to_binary ( SelectResult )"},
{expected,{selected,[{<<"43">>}]}},
{value,{selected,[]}}]},
[{rdbms_SUITE,do_test_incremental_upsert,1,
[{file,"/home/circleci/project/big_tests/tests/rdbms_SUITE.erl"},
{line,629}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_mnesia_26 / pgsql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} pgsql_mnesia_27 / pgsql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} mysql_redis_27 / mysql_redis / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} mssql_mnesia_27 / odbc_mssql_mnesia / 764f432 s2s_SUITE:node1_tls_required_trusted_node2_tls_optional:timeout_waiting_for_message{error,{test_case_failed,"got message but shouldn't"}} |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4391 +/- ##
==========================================
- Coverage 85.21% 85.17% -0.04%
==========================================
Files 550 550
Lines 33846 33864 +18
==========================================
+ Hits 28842 28845 +3
- Misses 5004 5019 +15 ☔ View full report in Codecov by Sentry. |
764f432
to
0b9d8b5
Compare
dynamic_domains_mysql_redis_27 / mysql_redis / 0b9d8b5 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 0b9d8b5 ldap_mnesia_27 / ldap_mnesia / 0b9d8b5 mysql_redis_27 / mysql_redis / 0b9d8b5 pgsql_cets_27 / pgsql_cets / 0b9d8b5 internal_mnesia_27 / internal_mnesia / 0b9d8b5 pgsql_mnesia_27 / pgsql_mnesia / 0b9d8b5 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 0b9d8b5 elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 0b9d8b5 pgsql_mnesia_26 / pgsql_mnesia / 0b9d8b5 ldap_mnesia_26 / ldap_mnesia / 0b9d8b5 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 0b9d8b5 small_tests_27 / small_tests / 0b9d8b5 small_tests_27_arm64 / small_tests / 0b9d8b5 small_tests_26 / small_tests / 0b9d8b5 |
0b9d8b5
to
db59cd7
Compare
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / db59cd7 small_tests_27 / small_tests / db59cd7 small_tests_26 / small_tests / db59cd7 small_tests_27_arm64 / small_tests / db59cd7 ldap_mnesia_27 / ldap_mnesia / db59cd7 ldap_mnesia_26 / ldap_mnesia / db59cd7 dynamic_domains_mysql_redis_27 / mysql_redis / db59cd7 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / db59cd7 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / db59cd7 internal_mnesia_27 / internal_mnesia / db59cd7 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / db59cd7 pgsql_cets_27 / pgsql_cets / db59cd7 mysql_redis_27 / mysql_redis / db59cd7 pgsql_mnesia_27 / pgsql_mnesia / db59cd7 cockroachdb_cets_27 / cockroachdb_cets / db59cd7 pubsub_SUITE:dag+node_affiliations:deny_no_owner_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alice_deny_no_owner_test_2879@localhost/res1">>,
escalus_tcp,<0.74800.0>,
[{event_manager,<0.74788.0>},
{server,<<"localhost">>},
{username,<<"alicE_deny_no_owner_test_2879">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.74788.0>},
{server,<<"localhost">>},
{username,<<"alicE_deny_no_owner_test_2879">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_deny_no_owner_test_2879">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_deny_no_owner_test_2879">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"bb8035be2127e61f">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,433}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,
"/home/c... pgsql_mnesia_26 / pgsql_mnesia / db59cd7 mssql_mnesia_27 / odbc_mssql_mnesia / db59cd7 cockroachdb_cets_27 / cockroachdb_cets / db59cd7 pubsub_SUITE:dag+manage_subscriptions:retrieve_node_subscriptions_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_retrieve_node_subscriptions_test_2878@localhost/res1">>,
escalus_tcp,<0.74941.0>,
[{event_manager,<0.74912.0>},
{server,<<"localhost">>},
{username,
<<"alicE_retrieve_node_subscriptions_test_2878">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.74912.0>},
{server,<<"localhost">>},
{username,
<<"alicE_retrieve_node_subscriptions_test_2878">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_retrieve_node_subscriptions_test_2878">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_retrieve_node_subscriptions_test_2878">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"4933bb8bc7d54c9f">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,433}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments. Additionally, a lot of coverage is missing, and actually the missing tests would catch the bug I pointed out.
?cfg(P ++ [verify_mode], none, T(#{<<"verify_mode">> => <<"none">>})), | ||
?cfg(P ++ [certfile], "priv/cert.pem", T(#{<<"certfile">> => <<"priv/cert.pem">>})), | ||
?cfg(P ++ [certfile], "priv/cert.pem", T(M#{<<"certfile">> => <<"priv/cert.pem">>})), | ||
?cfg(P ++ [cacertfile], "priv/ca.pem", T(tls_ca_raw())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?cfg(P ++ [cacertfile], "priv/ca.pem", T(tls_ca_raw())), | |
?cfg(P ++ [cacertfile], "priv/ca.pem", T(M)), |
@@ -945,7 +946,10 @@ process_root(Items) -> | |||
HTItems = lists:filter(fun(Item) -> is_host_type_item(Item, HostTypes) end, Items), | |||
case {unsupported_auth_methods(HTItems), unsupported_modules(HTItems)} of | |||
{[], []} -> | |||
Items; | |||
%% Reject config of s2s listeners that do not have `cacertfile` specified, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overloading this function to do more and more doesn't look like a good idea for me. This also doesn't work as expected, because you put it in a branch for dynamic domains. What was the motivation to move away from checking it in the s2s
listener code? Anyway, if you want to keep it here, I'd rather extend process_root
to be more generic and use a list of functions, folding over them. See the comment at the top - now it doesn't describe the function accurately.
TLS peer verification requires cacertificate, so it makes sense to reject config that misses cacertificate when verify_mode is set to verify_peer.
We have had this config validation for just_tls. This PR adds it for fast_tls.
Note that fast_tls currently skips certificate validation during TLS handshake but allows for certificate checks to happen later on during authentication.