-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core-validator.js #352
Conversation
WalkthroughThe recent update revises the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addErrors = true; | ||
_validationMessages = {}; | ||
|
||
constructor(...args) { | ||
super(...args); | ||
let validatorLocale; | ||
if (getOwner(this)) { | ||
validatorLocale = getOwner(this)?.lookup('validator:locale'); | ||
} | ||
|
||
this['_locale'] = this['_locale'] ?? (validatorLocale ? validatorLocale.locale : 'en'); | ||
set(this, '_validationMessages', Messages[this['_locale']]); | ||
} | ||
|
||
// to be implemented | ||
// clearErrors() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [14-14]
The comment "Clean all the current errors" is duplicated. This seems to be a minor copy-paste error and does not impact functionality but could be cleaned up for better readability.
- // Clean all the current errors
Summary by CodeRabbit
coreValidator
to enhance control flow and behavior related to setting locales and validation messages.