-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decamelize implemented, tested and documentation updated #467
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for the PR. equal(decamelize('theDecamelizeStringMethod_', ''), 'thedecamelizestringmethod_'); but the result is: AssertionError: 'the_decamelize_string_method_' == 'thedecamelizestringmethod_'
+ expected
- actual
+"thedecamelizestringmethod_"
-"the_decamelize_string_method_" |
@stoeffel - Great point. I didn't think about that case. The culprit for that is this I will change it to reflect the test case you just presented. |
Could you squash your commits and remove the |
It's cool! |
Removing dist artifact to follow pull request guidelines fixed empty string test fail
@dgolman could you also squash your commits to one? |
Removing dist artifact to follow pull request guidelines fixed empty string test fail decamelize implemented, tested and documentation updated Removing dist artifact to follow pull request guidelines fixed empty string test fail removing dist folder
@stoeffel I think the squash worked this time. Check it out. |
Nope it didn't work. but I will do it for you as soon as I have time. Thanks for the PR. |
The latest commit has all the commits in it. Just curious what I missed for On Thursday, January 14, 2016, Christoph Hermann [email protected]
|
You can squash the commits into one and force push it to the branch so only one commit appears. I think I have once seen a nice guide. I will check and send you the link |
This is a pull request to add the decamelize feature requested by @stoeffel in #407
Added file decamelize.js, tests, and updated documentation.