-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a command to select the package manager #14
Conversation
raisiqueira
commented
Jul 7, 2023
•
edited
Loading
edited
- Write unit tests for the new command.
Signed-off-by: Rai Siqueira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work ! This feature put us on a higher level in flexibility. But how we can safely implement tests so we know all package managers are properly handled? We can do using both app testing and github actions, but IDK what should be better! Besides that, I do not see anything wrong here.
ces sabem do que se trata esse frozen error aq? @raisiqueira @luigieai |
Signed-off-by: Rai Siqueira <[email protected]>
Signed-off-by: Rai Siqueira <[email protected]>
Signed-off-by: Rai Siqueira <[email protected]>
The package manager selector is just a "cosmetic" feature, basically this new command just removes the |
Signed-off-by: Rai Siqueira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's gooooo!