gitter: Fix occupants for GitterRoom #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The limit parameter was not used which defaults to 30 and returns maximum 100 users at a time. Hence, it fails to return all the members in the room. In order to tackle this, we need to iterate by skipping 100 members with every API request. Also users count needs to be updated everytime list of occupants is requested as new users may join a room in realtime. Closes errbotio#38
|
This might need some more testing, I made it in a hurry. I'll update by tomorrow if necessary. |
@nvzard Have you tested this? I would test it today or tomorrow :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit parameter was not used which defaults to 30
and returns maximum 100 users at a time. Hence, it fails
to return all the members in the room.
In order to tackle this, we need to iterate by skipping
100 members with every API request. Also users count
needs to be updated everytime list of occupants is
requested as new users may join a room in realtime.
Closes #38