[wip] e35 #7189
Closed
[wip] e35 #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
force-pushed
the
e35
branch
2 times, most recently
from
c81c1af
to
bda6a70
Compare
AskAlexSharov
force-pushed
the
e35
branch
2 times, most recently
from
e2ff1f6
to
b65eee1
Compare
Fm8914
approved these changes
Feb 6, 2024
go.mod
Outdated
| @@ -176,7 +176,7 @@ require ( | |||
| github.com/koron/go-ssdp v0.0.4 // indirect | |||
| github.com/kr/pretty v0.3.1 // indirect | |||
| github.com/kr/text v0.2.0 // indirect | |||
| github.com/ledgerwatch/erigon-snapshot v1.3.1-0.20240202034757-516749793a9d // indirect | |||
| github.com/ledgerwatch/erigon-snapshot v1.3.1-0.20240202101433-135828c6e0ff // indirect | |||
There was a problem hiding this comment.
Suggested change
| github.com/ledgerwatch/erigon-snapshot v1.3.1-0.20240202101433-135828c6e0ff // indirect | |
| github.com/ledgerwatch/erigon-snapshot v1.3.1-0.20240202101433-135828c6e0ff // indirect |
|
rename roFiles to visibleFiles
rename roFiles to visibleFiles
rename roFiles to visibleFiles
…10120) Before: If Flush() is blocked while Run() exits after insertBlocks() error or ctx.Done(), some tasks might be still in the queue, the waitGroup is not done, so waitGroup.Wait() won't exit and Flush() might hang (or leak its goroutine). Solution: Replace waitGroup with manual counting of tasks and a channel-based signal to Flush().
ExecutionEngine was meant for the engine API compatibility mode. Switch to using a generated ExecutionClient interface. We never need a remote mode and it always ends up being an instance of ExecutionClientDirect implemented by EthereumExecutionModule.
Since we are going ahead with a `Bridge` component managing its own DB for state sync events and a `Heimdall` component managing its own DB for checkpoints, milestones and spans this refactor is now due. I also need this so I can integrate the new `polygon/sync` in a `PolygonSyncStage` as part of this PR - #10124 so I can implement a `polygonSyncStageStore` specifically for the sync stage integration.
…ackage (#10129) We are using `storage` and `store` - would be good to stick to 1 for consistency, going ahead with store
Will be using `NewRwTxStore` in #10124 Idea is simple - split the current store in 2: - `roTxStore` - `rwTxStore` These 2 stores wrap around a tx with snapshots reader. The `rwTxStore` wraps around the `roTxStore` for code re-use. This split removes chances of unexpected `tx is read only` errors when calling the store update methods. Also, opens up a possibility to introduce a `dbRwStore` and `dbRoStore` wrappers around `roTxStore` and `rwTxStore` if we decide to go down this path. The `dbRwStore` in particular can have ownership over the lifetime of a `rwTxStore` - make sure only 1 is open at a time for example by using a channel/mutex/semaphore or some other idea and call `Rollback` and/or `Commit`. We may need to look into transitioning these to `TemporalTx` at some point - for now let's just get this to work first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.