Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create git tag before release build, small cosmetic changes. #12721

Merged
merged 9 commits into from
Nov 14, 2024

Conversation

lystopad
Copy link
Member

See #12661 for more details.
Changes:

  • workflow will create git tag referencing to the last commit id in "checkout_ref" (branch name as for now)
  • in case of not successful build -- second job will start and will remove git tag.
  • workflow will now contain useful name which reflects released version, branch used to build artifacts and person who run workflow.
  • latest docker base images debian:12.8-slim

Copy link
Member

@michelemodolo michelemodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me: approved.
Just remember to remove the linked tags in the automation which periodically purges images, otherwise we'd end up with a forest of orphaned tags.

@lystopad lystopad added this to the 2.60.11-fixes milestone Nov 14, 2024
@lystopad lystopad marked this pull request as ready for review November 14, 2024 11:12
@VBulikov VBulikov enabled auto-merge (squash) November 14, 2024 11:28
@VBulikov VBulikov merged commit 9d2d6a8 into release/2.60 Nov 14, 2024
15 checks passed
@VBulikov VBulikov deleted the feature/issue-12661 branch November 14, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants