Skip to content

Commit

Permalink
qa-tests: fix workflows for release 2.60 (#10217)
Browse files Browse the repository at this point in the history
Running a test every day doesn't make sense on an inactive branch. 
It also seems that the schedule trigger favours the main branch if the
test workflow has the same name on the main and other branches.
So this PR changes the test trigger to "push events".
  • Loading branch information
mriccobene authored May 6, 2024
1 parent 49e0171 commit 88680ca
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/qa-clean-exit-block-downloading.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@ name: QA - Clean exit (block downloading)
on:
push:
branches:
- main
- 'release/2.*'
pull_request:
branches:
- main
- 'release/2.*'
types:
- ready_for_review
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/qa-clean-exit-snapshot-downloading.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@ name: QA - Clean exit (snapshot downloading)
on:
push:
branches:
- main
- 'release/2.*'
pull_request:
branches:
- main
- 'release/2.*'
types:
- ready_for_review
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/qa-snap-download.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
name: QA - Snapshot Download

on:
schedule:
- cron: '5 0 * * *' # Run every day at 05:00 AM UTC
push:
branches:
- 'release/2.*'
pull_request:
branches:
- 'release/2.*'
types:
- ready_for_review
workflow_dispatch: # Run manually

jobs:
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/qa-tip-tracking.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
name: QA - Tip tracking

on:
schedule:
- cron: '0 0 * * *' # Run every day at 00:00 AM UTC
push:
branches:
- 'release/2.*'
pull_request:
branches:
- 'release/2.*'
types:
- ready_for_review
workflow_dispatch: # Run manually

jobs:
Expand Down

0 comments on commit 88680ca

Please sign in to comment.