net8 minimum. run gh action and macos and ubuntu as well.

ericsink · Jan 6, 2025 · fd96edb · fd96edb
1 parent dea4638
commit fd96edb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -11,8 +11,7 @@ jobs:
 
     strategy:
       matrix:
-        # TODO want macos here too, but the build currently fails there
-        os: [windows-2022]
+        os: [windows-2022, ubuntu-24.04, macos-14]
 
     runs-on: ${{ matrix.os }}
 

diff --git a/build/Program.fs b/build/Program.fs
@@ -78,7 +78,7 @@ let main argv =
         ]
 
     let fake_xunit_tfms = [
-        yield "net6.0"
+        yield "net8.0"
         if RuntimeInformation.IsOSPlatform(OSPlatform.Windows) then yield "net462"
         ]
 

diff --git a/version_stamp/version_stamp.cs b/version_stamp/version_stamp.cs
@@ -108,9 +108,9 @@ private static void gen_directory_build_props(string root, string nupkgs_dir_nam
             f.WriteElementString("depversion_xunit", "2.6.3");
             f.WriteElementString("depversion_xunit_runner_visualstudio", "2.5.5");
             f.WriteElementString("depversion_microsoft_net_test_sdk", "17.8.0");
-            f.WriteElementString("tfm_net", "net6.0");
+            f.WriteElementString("tfm_net", "net8.0");
             f.WriteElementString("tfm_framework", "net462");
-            f.WriteElementString("tfm_windows", "net6.0-windows");
+            f.WriteElementString("tfm_windows", "net8.0-windows");
             f.WriteElementString("tfm_ios", "net8.0-ios");
             f.WriteElementString("tfm_tvos", "net8.0-tvos");
             f.WriteElementString("tfm_maccatalyst", "net8.0-maccatalyst");