Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mongoose, i18n, element-ui, webpack, vue, vue-router #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abernov
Copy link

@abernov abernov commented Apr 11, 2018

Packages updated to latest versions:

  • mongoose
  • i18n
  • element-ui
  • vue

Updated nginx config

@abernov abernov changed the title Updated mongoose i18n element-ui webpack Updated mongoose, i18n, element-ui, webpack, vue, vue-router Apr 11, 2018
@abernov
Copy link
Author

abernov commented Apr 16, 2018

Failed to update to [email protected] - vue css is not working.
It is necessary to wait a little when to appear vue-loader@15 or extract-text-webpack-plugin@4.

Copy link
Owner

@erguotou520 erguotou520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks for your contribution for updating dependency and some mistake fixing.
But there're still some questions metioned in comments.

@@ -51,15 +51,15 @@ module.exports = {
"message": "Port that mock server listen at",
"default": 7878
},
"i18n": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change to i18nEn?

Copy link
Author

@abernov abernov Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in the Vue files a variable name must be i18n.

<script>
 import i18n from 'locales/things'
 export default {
   locales,
   i18n,
....

Therefore, the conditional translation variable was renamed to not coincide with the variable in the vue files

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables i18n in vue file are not wrapped with {{}}, so it does not affect these variables I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'm new (only a month) to node js.


charset utf-8;

access_log logs/vf-backend.access.log combined;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be access_log logs/{{name}}.access.log combined

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right

charset utf-8;

access_log logs/vf-backend.access.log combined;
error_log logs/vf-backend.error.log debug;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same above

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right

location ~* ^.+\.(html|htm)$ {
expires 1h;
}
#gzip on;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove?

# gzip_min_length 1k;

# gzip_comp_level 4;

# gzip_types text/plain application/javascript application/x-javascript text/css application/xml text/javascript application/x-httpd-php image/jpeg image/gif image/png;

# gzip_vary on;

# gzip_disable "MSIE [1-6]\.";

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand much in nginx. But your config did not work, but this one works.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous nginx.example.conf just contains the main configuration for nginx config file but not all. It's just a snippet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I combined yours nginx.example.conf with nginx default config and it all worked

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's welcome to do that. But add the missing block please.

@abernov
Copy link
Author

abernov commented Apr 17, 2018

I have working files for [email protected], But I was not able to connect the vue css.

Thank you for your great work.

@abernov
Copy link
Author

abernov commented Apr 17, 2018

There is still a mistake.

After run

NODE_ENV=production
npm run build

in the Chrome browser Vue Devtools is Available.

@erguotou520
Copy link
Owner

What's the problem in detail?

@abernov
Copy link
Author

abernov commented Apr 17, 2018

Vue Devtools should not be available In the production mode

In the production mode must be

Vue.config.devtools = false
`

@erguotou520
Copy link
Owner

Add this in client/main.js

@abernov
Copy link
Author

abernov commented Apr 17, 2018

Thank you. Can I sign a contract with you to work on my vue project?

@erguotou520
Copy link
Owner

What do u mean? Using this template at work?

@abernov
Copy link
Author

abernov commented Apr 17, 2018

Yes, I want to develop a project based on your template - Media Player Management Portal. It will be necessary to develop vue-components for the media library. It is possible that it is more profitable to use you to develop a front-end.

@erguotou520
Copy link
Owner

This template's license is MIT, so just use for any project. And it's welcome to share your project's repo or any website to me.

@abernov
Copy link
Author

abernov commented Apr 17, 2018

check your email

@erguotou520
Copy link
Owner

No mail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants