Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename validationData/executionData to validationStorage/executionStorage #199

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Oct 15, 2024

validationData collides with ERC-4337's variable name. h/t @0xrubes

@jaypaik jaypaik requested a review from a team October 15, 2024 18:20
Copy link

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • AccountStorage.sol: Renamed ExecutionData and ValidationData to ExecutionStorage and ValidationStorage.
  • ModularAccountView.sol: The smart contract modified variable names from ExecutionData/ValidationData to ExecutionStorage/ValidationStorage.
  • ModuleManagerInternals.sol: Updated smart contract modifies data-related storage types, renaming ExecutionData to ExecutionStorage and ValidationData to ValidationStorage.
  • ReferenceModularAccount.sol: The smart contract modifies property references from "executionData" and "validationData" to "executionStorage" and "validationStorage," enhancing data organization.

🔗 Commit Hash: bdc7e7d

This comment was marked as resolved.

@jaypaik jaypaik merged commit c75f885 into develop Oct 15, 2024
4 checks passed
@jaypaik jaypaik deleted the 10-15-fix_rename_validationData/executionData_to_validationStorage/executionStorage branch October 15, 2024 18:29
jaypaik added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants