Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-create package-lock for storybook #246

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

johannesleite
Copy link
Contributor

This needs confirmation if it should be done or not. It adds resolved and integrity to all entries in package-lock and updating a bunch of the packages in there.

@johannesleite
Copy link
Contributor Author

@fbosquet-azpn any opinion on this?

@johannesleite johannesleite requested a review from a team April 12, 2024 05:31
@fbosquet-azpn
Copy link
Contributor

@fbosquet-azpn any opinion on this?

I usually try to avoid directly modifying the package-lock.json unless it's necessary to fix a critical security issue that can't be resolved by simply upgrading a version in the package.json file first.

How was this package-lock updated? Do you know if it resulted from running npm audit fix or something else?

@johannesleite
Copy link
Contributor Author

I usually try to avoid directly modifying the package-lock.json unless it's necessary to fix a critical security issue that can't be resolved by simply upgrading a version in the package.json file first.

How was this package-lock updated? Do you know if it resulted from running npm audit fix or something else?

@fbosquet-azpn It was updated by deleting it, deleting node modules and installing packages again.

It resolves some vulnerabilities that Snyk reported: #244 and #242

@VRiveland VRiveland merged commit f4a3a84 into dev Apr 30, 2024
4 checks passed
@johannesleite johannesleite deleted the chore-recreate_package-lock branch May 1, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants