Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean and stdev of intermediate field parameters #757

Merged

Conversation

oddvarlia
Copy link
Collaborator

Purpose:
For QC purpose it could be useful to check mean and stdev also for intermediate/temporary field parameters that are saved under <RUN_PATH>/rms/output/aps directory for initial ensemble field parameters and on <RUN_PATH> for updated field parameters. Here the GRF's for APS and possibly also transformed gaussian fields for petrophysical parameters are saved per facies per zone.
This can be specified by some additional keywords in the input config file for the field_statistics.py script

@oddvarlia oddvarlia marked this pull request as draft October 24, 2024 10:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 48.78049% with 63 lines in your changes missing coverage. Please review.

Project coverage is 85.15%. Comparing base (c6cef12) to head (685342e).

Files with missing lines Patch % Lines
src/subscript/field_statistics/field_statistics.py 48.78% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   85.80%   85.15%   -0.65%     
==========================================
  Files          52       52              
  Lines        7342     7418      +76     
==========================================
+ Hits         6300     6317      +17     
- Misses       1042     1101      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddvarlia oddvarlia force-pushed the field_stat_for_intermediate_parameters branch 5 times, most recently from 29fec6c to 7230957 Compare October 25, 2024 07:38
@oddvarlia oddvarlia marked this pull request as ready for review October 25, 2024 10:10
@oddvarlia oddvarlia requested a review from alifbe October 25, 2024 10:14
@oddvarlia oddvarlia marked this pull request as draft October 25, 2024 11:06
@oddvarlia oddvarlia force-pushed the field_stat_for_intermediate_parameters branch 4 times, most recently from 77bcbaf to ff6d2f3 Compare October 28, 2024 08:37
@oddvarlia oddvarlia force-pushed the field_stat_for_intermediate_parameters branch from f665a52 to bf8c374 Compare October 29, 2024 09:32
@oddvarlia oddvarlia marked this pull request as ready for review October 29, 2024 10:33
@oddvarlia oddvarlia requested a review from alifbe October 29, 2024 10:33
Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oddvarlia oddvarlia force-pushed the field_stat_for_intermediate_parameters branch from bf8c374 to 83f54d3 Compare October 29, 2024 13:55
…mporary field parameters located in rms/output/aps directory

Redefine config file format to support both types of fields (both result fields in geogrid and temporary fields)

 #update_test_field_statistics
@oddvarlia oddvarlia force-pushed the field_stat_for_intermediate_parameters branch from 83f54d3 to 685342e Compare October 29, 2024 13:58
@oddvarlia oddvarlia merged commit 16807f3 into equinor:main Oct 29, 2024
6 checks passed
@alifbe alifbe linked an issue Nov 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants