-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mean and stdev of intermediate field parameters #757
Merged
oddvarlia
merged 1 commit into
equinor:main
from
oddvarlia:field_stat_for_intermediate_parameters
Oct 29, 2024
Merged
Mean and stdev of intermediate field parameters #757
oddvarlia
merged 1 commit into
equinor:main
from
oddvarlia:field_stat_for_intermediate_parameters
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 85.80% 85.15% -0.65%
==========================================
Files 52 52
Lines 7342 7418 +76
==========================================
+ Hits 6300 6317 +17
- Misses 1042 1101 +59 ☔ View full report in Codecov by Sentry. |
oddvarlia
force-pushed
the
field_stat_for_intermediate_parameters
branch
5 times, most recently
from
October 25, 2024 07:38
29fec6c
to
7230957
Compare
oddvarlia
force-pushed
the
field_stat_for_intermediate_parameters
branch
4 times, most recently
from
October 28, 2024 08:37
77bcbaf
to
ff6d2f3
Compare
alifbe
reviewed
Oct 29, 2024
alifbe
reviewed
Oct 29, 2024
alifbe
reviewed
Oct 29, 2024
alifbe
reviewed
Oct 29, 2024
alifbe
reviewed
Oct 29, 2024
oddvarlia
force-pushed
the
field_stat_for_intermediate_parameters
branch
from
October 29, 2024 09:32
f665a52
to
bf8c374
Compare
alifbe
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oddvarlia
force-pushed
the
field_stat_for_intermediate_parameters
branch
from
October 29, 2024 13:55
bf8c374
to
83f54d3
Compare
…mporary field parameters located in rms/output/aps directory Redefine config file format to support both types of fields (both result fields in geogrid and temporary fields) #update_test_field_statistics
oddvarlia
force-pushed
the
field_stat_for_intermediate_parameters
branch
from
October 29, 2024 13:58
83f54d3
to
685342e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
For QC purpose it could be useful to check mean and stdev also for intermediate/temporary field parameters that are saved under <RUN_PATH>/rms/output/aps directory for initial ensemble field parameters and on <RUN_PATH> for updated field parameters. Here the GRF's for APS and possibly also transformed gaussian fields for petrophysical parameters are saved per facies per zone.
This can be specified by some additional keywords in the input config file for the field_statistics.py script