Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detect rhel version to testkomodo script #664

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Feb 21, 2024

Resolves #663

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.26%. Comparing base (011afce) to head (9ad525c).
Report is 2 commits behind head on main.

❗ Current head 9ad525c differs from pull request most recent head c779d6f. Consider uploading reports for the commit c779d6f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files          50       50           
  Lines        6990     6991    +1     
=======================================
+ Hits         6030     6031    +1     
  Misses        960      960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el force-pushed the avoid_hardcoded_rhel_version branch from 268b8f4 to a096788 Compare February 22, 2024 08:05
@andreas-el andreas-el requested a review from larsevj February 22, 2024 08:19
tests/test_ri_wellmod.py Outdated Show resolved Hide resolved
@andreas-el andreas-el force-pushed the avoid_hardcoded_rhel_version branch from ea027ba to c779d6f Compare February 22, 2024 19:33
@andreas-el andreas-el requested a review from berland February 23, 2024 09:00
Copy link
Collaborator

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andreas-el andreas-el merged commit 289e48d into main Feb 23, 2024
6 checks passed
@andreas-el andreas-el deleted the avoid_hardcoded_rhel_version branch February 23, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscript testing uses hardcoded paths binaries and libraries
4 participants