Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CASEGEN_UPCARS forward model #649

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add CASEGEN_UPCARS forward model #649

merged 2 commits into from
Jan 16, 2024

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Jan 12, 2024

Add forward model description for CASEGEN_UPCARS and use logger to print out information/warning

@alifbe alifbe force-pushed the casegen_upcars_forward_model branch from 01a35d5 to 21893cb Compare January 12, 2024 13:57
@alifbe alifbe force-pushed the casegen_upcars_forward_model branch from 21893cb to 48f6f70 Compare January 12, 2024 14:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ff349b9) 86.12% compared to head (a44d358) 86.13%.

❗ Current head a44d358 differs from pull request most recent head 3fe6977. Consider uploading reports for the commit 3fe6977 to get more accurate results

Files Patch % Lines
src/subscript/casegen_upcars/casegen_upcars.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   86.12%   86.13%           
=======================================
  Files          50       50           
  Lines        7065     7069    +4     
=======================================
+ Hits         6085     6089    +4     
  Misses        980      980           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alifbe alifbe requested review from mferrera and rnyb January 12, 2024 22:02
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from Roger's comment the code LGTM 👍

@alifbe alifbe requested a review from rnyb January 15, 2024 22:03
@alifbe alifbe merged commit 6e675c1 into main Jan 16, 2024
5 checks passed
@alifbe alifbe deleted the casegen_upcars_forward_model branch January 16, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants